Skip to content

8351487: [ubsan] jvmti.h runtime error: load of value which is not a valid value #26159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

8351487: [ubsan] jvmti.h runtime error: load of value which is not a valid value #26159

wants to merge 2 commits into from
+8 −2

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Jul 7, 2025 •
edited by openjdk bot
Loading

When running with ubsan - enabled binaries, the following 2 issues are observed in jvmti.h (on macOS aarch64).

jtreg test vmTestbase/nsk/jvmti/SetVerboseFlag/setvrbflag002/TestDescription.java 

/priv/jenkins/client-home/workspace/openjdk-jdk-weekly-macos_aarch64-opt/build/support/modules_include/java.base/jvmti.h:2645:44: runtime error: load of value 4294967295, which is not a valid value for type 'jvmtiVerboseFlag'
    #0 0x104453540 in _jvmtiEnv::SetVerboseFlag(jvmtiVerboseFlag, unsigned char) jvmti.h:2645
    #1 0x10444ed5c in agentProc(_jvmtiEnv*, JNIEnv_*, void*) setvrbflag002.cpp:49
    #2 0x10444f1c8 in agentThreadWrapper(_jvmtiEnv*, JNIEnv_*, void*) agent_tools.cpp:151
    #3 0x10914895c in JvmtiAgentThread::call_start_function() jvmtiImpl.cpp:89
    #4 0x108ebd7f0 in JavaThread::thread_main_inner() javaThread.cpp:776
    #5 0x1096f6094 in Thread::call_run() thread.cpp:231
    #6 0x10941c37c in thread_native_entry(Thread*) os_bsd.cpp:601
    #7 0x1936fef90 in _pthread_start+0x84 (libsystem_pthread.dylib:arm64e+0x6f90)
    #8 0x1936f9d30 in thread_start+0x4 (libsystem_pthread.dylib:arm64e+0x1d30)

vmTestbase/nsk/jvmti/GetErrorName/geterrname002/TestDescription.java

/priv/jenkins/client-home/workspace/openjdk-jdk-weekly-macos_aarch64-opt/build/support/modules_include/java.base/jvmti.h:2640:42: runtime error: load of value 4294967295, which is not a valid value for type 'jvmtiError'
    #0 0x1002b3504 in _jvmtiEnv::GetErrorName(jvmtiError, char**) jvmti.h:2640
    #1 0x1002aec9c in agentProc(_jvmtiEnv*, JNIEnv_*, void*) geterrname002.cpp:50
    #2 0x1002af198 in agentThreadWrapper(_jvmtiEnv*, JNIEnv_*, void*) agent_tools.cpp:151
    #3 0x104f4895c in JvmtiAgentThread::call_start_function() jvmtiImpl.cpp:89
    #4 0x104cbd7f0 in JavaThread::thread_main_inner() javaThread.cpp:776
    #5 0x1054f6094 in Thread::call_run() thread.cpp:231
    #6 0x10521c37c in thread_native_entry(Thread*) os_bsd.cpp:601
    #7 0x1936fef90 in _pthread_start+0x84 (libsystem_pthread.dylib:arm64e+0x6f90)
    #8 0x1936f9d30 in thread_start+0x4 (libsystem_pthread.dylib:arm64e+0x1d30)

So the problem reported is SetVerboseFlag method (which is part of the VM) calls SetVerboseFlag function with that bad argument ; but the test code seems to intentionally use 'bad' arguments . But this does not work well with ubsan ; so better exclude those tests from ubsan checking .
Please note that jvmti.h is shipped so adding some macros/attributes to methods for avoiding ubsan is probably not the best thing to do in this case.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8351487: [ubsan] jvmti.h runtime error: load of value which is not a valid value (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26159/head:pull/26159
$ git checkout pull/26159

Update a local copy of the PR:
$ git checkout pull/26159
$ git pull https://git.openjdk.org/jdk.git pull/26159/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26159

View PR using the GUI difftool:
$ git pr show -t 26159

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26159.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 7, 2025

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 7, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title JDK-8351487: [ubsan] jvmti.h runtime error: load of value which is not a valid value 8351487: [ubsan] jvmti.h runtime error: load of value which is not a valid value Jul 7, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 7, 2025
@openjdk
Copy link

openjdk bot commented Jul 7, 2025

@MBaesken The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Jul 7, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 7, 2025 •
edited
Loading

Webrevs

plummercj
plummercj suggested changes Jul 7, 2025
View reviewed changes
Copy link
Contributor

@plummercj plummercj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is somewhat of an odd situation. SetVerboseFlag() says the argument type is an enum, but it treats it like an int and does error checking to make sure it one of the enum values. If ubsan dug a little deeper to see how the argument is handled, it would see that and not complain.

alexmenkov
alexmenkov reviewed Jul 8, 2025
View reviewed changes
test/hotspot/jtreg/vmTestbase/nsk/jvmti/GetErrorName/geterrname002/TestDescription.java
@@ -35,6 +35,9 @@
* JVMTI_ERROR_NULL_POINTER if name_ptr is NULL.
* COMMENTS
*
* @requires !vm.ubsan
* @comment We test with arguments out of scope of the jvmti enums, this causes
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please place the comments before @requires tags

plummercj
plummercj reviewed Jul 8, 2025
View reviewed changes
test/hotspot/jtreg/vmTestbase/nsk/jvmti/GetErrorName/geterrname002/TestDescription.java
Comment on lines +39 to +40
* @comment We test with arguments out of scope of the jvmti enums, this causes
* ubsan issues.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @comment We test with arguments out of scope of the jvmti enums, this causes
* ubsan issues.
* @comment We test with arguments out of scope of the jvmti enums, which causes
* ubsan issues.

test/hotspot/jtreg/vmTestbase/nsk/jvmti/SetVerboseFlag/setvrbflag002/TestDescription.java
Comment on lines +38 to +39
* @comment We test with arguments out of scope of the jvmti enums, this causes
* ubsan issues.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @comment We test with arguments out of scope of the jvmti enums, this causes
* ubsan issues.
* @comment We test with arguments out of scope of the jvmti enums, which causes
* ubsan issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plummercj plummercj plummercj requested changes

@alexmenkov alexmenkov alexmenkov left review comments

Assignees
No one assigned
Labels
rfr Pull request is ready for review serviceability serviceability-dev@openjdk.org
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MBaesken @plummercj @alexmenkov